rdblue commented on a change in pull request #3817:
URL: https://github.com/apache/iceberg/pull/3817#discussion_r776883074
##########
File path:
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java
##########
@@ -226,7 +226,7 @@ private void writeRecords(List<Record> records) throws
IOException {
}
private StreamingMonitorFunction createFunction(ScanContext scanContext) {
- return new
StreamingMonitorFunction(TestTableLoader.of(tableDir.getAbsolutePath()),
scanContext);
+ return new
StreamingMonitorFunction(TestTableLoader.of(tableDir.getAbsolutePath()),
scanContext, false);
Review comment:
Where is this called from? Is it okay to do this or should locality be
part of the scan context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
