rdblue commented on a change in pull request #3840:
URL: https://github.com/apache/iceberg/pull/3840#discussion_r778219541



##########
File path: 
spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -244,6 +244,7 @@ private boolean requiresRewrite(Filter filter, Schema 
schema, Set<Integer> ident
 
   @Override
   public void deleteWhere(Filter[] filters) {
+    canDeleteWhere(filters);

Review comment:
       This is where the check is done for the other versions of Spark, but 
adding `canDeleteWhere` here is expensive and not the right solution. Can you 
add the precondition instead?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to