rdblue commented on a change in pull request #3840:
URL: https://github.com/apache/iceberg/pull/3840#discussion_r778357745
##########
File path:
spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java
##########
@@ -244,6 +244,10 @@ private boolean requiresRewrite(Filter filter, Schema
schema, Set<Integer> ident
@Override
public void deleteWhere(Filter[] filters) {
+ Preconditions.checkArgument(
+ snapshotId == null,
+ "Cannot delete from table at a specific snapshot: %s", snapshotId);
+
Review comment:
I don't think that the implementation of `canDeleteWhere` matters much
for Spark 3.0. We could simply remove the function since it is unused, but it
doesn't seem worth letting the code drift either to remove it or to modify it
to have this check in just one place. So I guess I disagree with this
suggestion. Let's just leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
