stevenzwu commented on a change in pull request #3681:
URL: https://github.com/apache/iceberg/pull/3681#discussion_r778266930
##########
File path:
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
##########
@@ -377,6 +378,23 @@ void createIcebergTable(ObjectPath tablePath,
CatalogBaseTable table, boolean ig
PartitionSpec spec = toPartitionSpec(((CatalogTable)
table).getPartitionKeys(), icebergSchema);
ImmutableMap.Builder<String, String> properties = ImmutableMap.builder();
+
+ List<WatermarkSpec> watermarkSpecs = table.getSchema().getWatermarkSpecs();
+ if (watermarkSpecs != null) {
+ for (int i = 0; i < watermarkSpecs.size(); i++) {
Review comment:
I am not familiar with that part of Flink. can you help me understand
the list of watermark spec? is it to define multiple watermark strategies and
writer can pick one strategy to use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
