stevenzwu commented on a change in pull request #3681:
URL: https://github.com/apache/iceberg/pull/3681#discussion_r778280984
##########
File path:
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java
##########
@@ -172,4 +208,16 @@ public static TableSchema toSchema(Schema schema) {
return builder.build();
}
+
+ private static Optional<String> optionalGet(String key, Map<String, String>
properties) {
+ return Optional.ofNullable(properties.get(key));
+ }
+
+ private static Supplier<TableException> exceptionSupplier(String key) {
+ return () -> {
+ throw new TableException(
+ "Property with key '" + key + "' could not be found. " +
+ "This is a bug because the validation logic should have checked
that before.");
Review comment:
nit: this part seems redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
