stevenzwu commented on a change in pull request #3681:
URL: https://github.com/apache/iceberg/pull/3681#discussion_r778991249
##########
File path:
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java
##########
@@ -52,6 +59,8 @@
*/
public class FlinkSchemaUtil {
+ public static final String flinkPrefix = "flink.";
Review comment:
static variable name should be all upper cases.
also I am not sure this is the right class to host this constant. I am
wondering if we should introduce a `FlinkTableProperties` to host this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
