hameizi commented on a change in pull request #3681:
URL: https://github.com/apache/iceberg/pull/3681#discussion_r778574501
##########
File path:
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java
##########
@@ -149,14 +156,43 @@ public static TableSchema toSchema(RowType rowType) {
* @param schema iceberg schema to convert.
* @return Flink TableSchema.
*/
- public static TableSchema toSchema(Schema schema) {
+ public static TableSchema toSchema(Schema schema, Map<String, String>
properties) {
TableSchema.Builder builder = TableSchema.builder();
// Add columns.
for (RowType.RowField field : convert(schema).getFields()) {
builder.field(field.getName(),
TypeConversions.fromLogicalToDataType(field.getType()));
}
+ // Add watermark
+ final int watermarkCount =
+ properties.keySet().stream()
+ .filter(
+ (k) ->
Review comment:
This logic is similar to flink's. So i think it is more suitable, and we
can update it with flink version in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
