RussellSpitzer commented on a change in pull request #3845:
URL: https://github.com/apache/iceberg/pull/3845#discussion_r780412042
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -337,16 +337,22 @@ private void checkAndAddPartitionName(String name) {
}
private void checkAndAddPartitionName(String name, Integer sourceColumnId)
{
+ checkAndAddPartitionName(name, sourceColumnId, true);
+ }
+
+ private void checkAndAddPartitionName(String name, Integer sourceColumnId,
boolean checkConflict) {
Types.NestedField schemaField = schema.findField(name);
- if (sourceColumnId != null) {
- // for identity transform case we allow conflicts between partition
and schema field name as
- // long as they are sourced from the same schema field
- Preconditions.checkArgument(schemaField == null ||
schemaField.fieldId() == sourceColumnId,
- "Cannot create identity partition sourced from different field in
schema: %s", name);
- } else {
- // for all other transforms we don't allow conflicts between partition
name and schema field name
- Preconditions.checkArgument(schemaField == null,
- "Cannot create partition from name that exists in schema: %s",
name);
+ if (checkConflict) {
Review comment:
In this case it's because we arent "really" making a partitioning spec,
we are just using it to get the transform so that pushdown will work correctly.
The Metadata Table needs a way to convert where "x = 5" into where "partition.x
= 5", normally we wouldn't allow you to make a partition column "partition" on
the element of a field named "partition" because it would be ambiguous but here
it isn't since we know we must be referring to the nested "partition" and not
the parent one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
