huaxingao commented on a change in pull request #3845:
URL: https://github.com/apache/iceberg/pull/3845#discussion_r780411253



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetadataTable.java
##########
@@ -63,7 +63,8 @@ protected BaseMetadataTable(TableOperations ops, Table table, 
String name) {
    */
   static PartitionSpec transformSpec(Schema metadataTableSchema, PartitionSpec 
spec, String partitionPrefix) {
     PartitionSpec.Builder identitySpecBuilder = 
PartitionSpec.builderFor(metadataTableSchema);

Review comment:
       Fixed. Thanks!

##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -336,17 +338,24 @@ private void checkAndAddPartitionName(String name) {
       checkAndAddPartitionName(name, null);
     }
 
+    Builder checkConflict(boolean check) {

Review comment:
       Done. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to