rdblue commented on a change in pull request #3104:
URL: https://github.com/apache/iceberg/pull/3104#discussion_r780846129
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -238,6 +240,8 @@ public String toString() {
private final Map<Integer, SortOrder> sortOrdersById;
private final List<HistoryEntry> snapshotLog;
private final List<MetadataLogEntry> previousFiles;
+ private final Map<String, SnapshotRef> refs;
+ private final SetMultimap<Long, SnapshotRef> refsById;
Review comment:
I don't understand why these are indexed by snapshot rather than name.
Is that a common pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
