rdblue commented on a change in pull request #3104: URL: https://github.com/apache/iceberg/pull/3104#discussion_r780845655
########## File path: api/src/main/java/org/apache/iceberg/SnapshotRef.java ########## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import java.io.Serializable; +import java.util.Objects; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; + +public class SnapshotRef implements Serializable { + + public static final String MAIN_BRANCH = "main"; + + private final long snapshotId; + private final SnapshotRefType type; + private final Integer minSnapshotsToKeep; + private final Long maxSnapshotAgeMs; + private final Long maxRefAgeMs; + + private SnapshotRef( + long snapshotId, + SnapshotRefType type, + Integer minSnapshotsToKeep, + Long maxSnapshotAgeMs, + Long maxRefAgeMs) { + this.snapshotId = snapshotId; + this.type = type; + this.minSnapshotsToKeep = minSnapshotsToKeep; + this.maxSnapshotAgeMs = maxSnapshotAgeMs; + this.maxRefAgeMs = maxRefAgeMs; + } + + public long snapshotId() { + return snapshotId; + } + + public SnapshotRefType type() { + return type; + } + + public Integer minSnapshotsToKeep() { + return minSnapshotsToKeep; + } + + public Long maxSnapshotAgeMs() { + return maxSnapshotAgeMs; + } + + public Long maxRefAgeMs() { + return maxRefAgeMs; + } + + public static Builder builderForTag(long snapshotId) { + return builderFor(snapshotId, SnapshotRefType.TAG); + } + + public static Builder builderForBranch(long snapshotId) { + return builderFor(snapshotId, SnapshotRefType.BRANCH); + } + + public static Builder builderFrom(SnapshotRef ref) { + return new Builder(ref.type()) + .snapshotId(ref.snapshotId()) Review comment: Why use a builder method for snapshot ID when it is passed in through the factory method? What happens when you try to change the snapshot ID or set it to null? I think it may be simpler just to make this a `private final` field and remove the builder method for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
