stevenzwu commented on a change in pull request #3817:
URL: https://github.com/apache/iceberg/pull/3817#discussion_r780850803
##########
File path:
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScanSql.java
##########
@@ -178,6 +179,38 @@ public void testInferedParallelism() throws IOException {
Assert.assertEquals("Should produce the expected parallelism.", 1,
parallelism);
}
+ @Test
+ public void testExposeLocality() throws Exception {
Review comment:
It only verifies data read. this doesn't really verify locality aware
assignment. Ideally, we need 2 files stored in 2 hosts with HDFS and run a
cluster of TMs on those two hosts. Then we can verify the assigned files/splits
are from the same host. But I am not sure if this can be done in a unit test
setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
