stevenzwu commented on a change in pull request #3817:
URL: https://github.com/apache/iceberg/pull/3817#discussion_r784540128
##########
File path:
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScanSql.java
##########
@@ -178,6 +179,38 @@ public void testInferedParallelism() throws IOException {
Assert.assertEquals("Should produce the expected parallelism.", 1,
parallelism);
}
+ @Test
+ public void testExposeLocality() throws Exception {
Review comment:
this is for unit test the assigner, not an e2e test of the whole thing.
Except for this lack of e2e test, PR overall looks good to me. Have you tested
this in a hadoop cluster setup manually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
