RussellSpitzer commented on a change in pull request #3774:
URL: https://github.com/apache/iceberg/pull/3774#discussion_r784203495
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetSchemaUtil.java
##########
@@ -164,4 +164,48 @@ public Boolean primitive(PrimitiveType primitive) {
}
}
+ // Parquet LIST backwards-compatibility rules.
+ //
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#backward-compatibility-rules
+ public static boolean isListElementType(Type repeatedType, String
parentName) {
Review comment:
Perhaps this should be isOldListElementType or something to indicate
this is for backwards compatibility in the name, we also switch the name to
"isElementType" later which I think we should also rename to show this is the
backwards compatibility path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
