SinghAsDev commented on a change in pull request #3774:
URL: https://github.com/apache/iceberg/pull/3774#discussion_r786228377
##########
File path:
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetSchemaUtil.java
##########
@@ -204,6 +204,55 @@ public void testSchemaConversionForHiveStyleLists() {
Assert.assertEquals("Schema must match", expectedSchema.asStruct(),
actualSchema.asStruct());
}
+ @Test
+ public void testSchemaConversionForHiveStyleTwoLevelList() {
Review comment:
The other two cases which are specific to avro and thrift are only
different in how they name the element, which we don;t care about and is tested
by other two level lists tests. However, it is definitely a good idea to
explicitly add tests even if they are a bit redundant as it helps in
understanding behavior expectations. Adding it shortly, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
