SinghAsDev commented on a change in pull request #3774:
URL: https://github.com/apache/iceberg/pull/3774#discussion_r795248128
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -149,6 +142,29 @@
}
}
+ private static <T> T visitTwoLevelList(Types.ListType iListType,
Types.NestedField iListElement, GroupType pListType,
+ Type pListElement, TypeWithSchemaVisitor<T> visitor) {
+ T elementResult = visitField(iListElement, pListElement, visitor);
+
Review comment:
I think the style used in various parts of code are different. For
example, IIUC `ParquetReadSupport.prepareForRead` is different than what you
are saying. Earlier you also had mentioned Iceberg does not use new param at
new line pattern. Updating this part to keep the same level (align params start
with previous line) and wrap.
Let me know which style we should try to follow and I can try to update the
intellij-style that we provide with Iceberg repo accordingly. I don't know if
it is possible, but I can try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
