flyrain commented on a change in pull request #2638:
URL: https://github.com/apache/iceberg/pull/2638#discussion_r788082408
##########
File path: api/src/main/java/org/apache/iceberg/io/InputFile.java
##########
@@ -59,4 +60,18 @@
* @return true if the file exists, false otherwise
*/
boolean exists();
+
+ // TODO remove this comment after review
Review comment:
Brainstorming an idea with trait-like solution:
1. Create a new interface for encryption file or reuse the interface
`EncryptedInputFile`, which will have method `getNativeDecryptionParameters`
and `setNativeDecryptionParameters`.
2. The subclass(HadoopInputFile, S3InputFile, etc) can implement both
`InputFile` and the `EncryptedInputFile`.
3. In case of the caller side, we can invoke it like this
`((EncryptedInputFile)inputFile).getNativeDecryptionParameters()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
