ggershinsky commented on a change in pull request #2638:
URL: https://github.com/apache/iceberg/pull/2638#discussion_r788674371
##########
File path: api/src/main/java/org/apache/iceberg/io/InputFile.java
##########
@@ -59,4 +60,18 @@
* @return true if the file exists, false otherwise
*/
boolean exists();
+
+ // TODO remove this comment after review
Review comment:
I like this idea. Regarding the details - using `EncryptedInputFile`
directly won't work (because this is a producer/decryptor of input files; an
object shouldn't be both an input file and its decryptor) - but we can add a
new interface, something like `NativeEncryption`, and make the classes
implement it. Moreover, we can apply this to output files, not only to input
files. I'll play with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
