kbendick opened a new pull request #3938: URL: https://github.com/apache/iceberg/pull/3938
…ther empty characters In the REST catalog, we have decided to use a NULL_BYTE to delimit certain portions of a `Namespace`. To prepare for that, we should disallow any level which contains a NULL_BYTE character (technically either the deprecated `\0` or the unicode character `\u0000`). It also doesn't make sense for a level to be null, so I've added a check for that as well. Added tests and I also tested the regular expression against a large number of patterns in a Scala REPL. I can make the regular expression simpler (just matching on `\0` or `\u0000`), but I don't think it makes sense for any namespace to have whitespace in it at all. Are there any systems where users could have a catalog table such as `hive_catalog.\\`wow who named me\\`.tbl`", where backticks are used to escape on the spaces? Even if so, it seems.... not that advisable. I'm happy to remove the stricter whitespace check in favor of just checking for null-byte (so that future work won't accidentally allow the null-byte character to pass into the namespace silently). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
