kbendick removed a comment on pull request #3938:
URL: https://github.com/apache/iceberg/pull/3938#issuecomment-1017968614
Looks like my emptiness / null check on namespace levels broke some of the
existing tests: I'll take a look at them and then either remove that check (all
that's really needed is the null-byte check) or update the tests if they're
possibly expecting to fail later in the process or something.
```
org.apache.iceberg.aws.glue.TestIcebergToGlueConverter >
testToDatabaseNameFailure FAILED
java.lang.IllegalArgumentException: Cannot create a namespace with a
null or empty level
at
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at org.apache.iceberg.catalog.Namespace.of(Namespace.java:48)
at
org.apache.iceberg.aws.glue.TestIcebergToGlueConverter.testToDatabaseNameFailure(TestIcebergToGlueConverter.java:54)
65 tests completed, 1 failed
> Task :iceberg-aws:test FAILED
> Task :iceberg-core:test
org.apache.iceberg.jdbc.TestJdbcCatalog > testListNamespace FAILED
java.lang.IllegalArgumentException: Cannot create a namespace with a
null or empty level
at
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at org.apache.iceberg.catalog.Namespace.of(Namespace.java:48)
at
org.apache.iceberg.jdbc.JdbcUtil.stringToNamespace(JdbcUtil.java:80)
at
org.apache.iceberg.jdbc.JdbcCatalog.lambda$listNamespaces$4(JdbcCatalog.java:270)
at org.apache.iceberg.ClientPoolImpl.run(ClientPoolImpl.java:58)
at org.apache.iceberg.ClientPoolImpl.run(ClientPoolImpl.java:51)
at
org.apache.iceberg.jdbc.JdbcCatalog.listNamespaces(JdbcCatalog.java:262)
at
org.apache.iceberg.catalog.SupportsNamespaces.listNamespaces(SupportsNamespaces.java:75)
at
org.apache.iceberg.jdbc.TestJdbcCatalog.testListNamespace(TestJdbcCatalog.java:478)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
