rdblue commented on a change in pull request #3774:
URL: https://github.com/apache/iceberg/pull/3774#discussion_r790075128
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -76,16 +81,22 @@
element = list.fields().get(0);
}
- visitor.fieldNames.push(repeatedElement.getName());
+ if (!isOldListElementType) {
+ visitor.fieldNames.push(repeatedElement.getName());
+ }
Review comment:
This needs newlines between control flow blocks. It also warrants a
comment about why this is skipping the name handling.
I think I would also handle the 2-level lists separately at a higher level,
rather than checking `isOldListElementType` 3 times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
