rdblue commented on a change in pull request #3774:
URL: https://github.com/apache/iceberg/pull/3774#discussion_r791320410
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -149,6 +134,50 @@
}
}
+ private static <T> T visitTwoLevelList(
+ org.apache.iceberg.types.Type iType,
+ TypeWithSchemaVisitor<T> visitor,
+ GroupType group,
+ Type repeatedElement) {
+ Types.ListType list = null;
+ Types.NestedField element = null;
+ if (iType != null) {
+ list = iType.asListType();
Review comment:
This can be pushed up to the method call. `iType.asListType()` passed in
here makes the signature of this method simpler, `Types.ListType`. Same with
the other method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
