rdblue commented on a change in pull request #3774:
URL: https://github.com/apache/iceberg/pull/3774#discussion_r791321420
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetTypeVisitor.java
##########
@@ -66,17 +66,16 @@
Preconditions.checkArgument(list.getFieldCount() == 1,
"Invalid list: does not contain single repeated field: %s", list);
- GroupType repeatedElement = list.getFields().get(0).asGroupType();
+ Type repeatedElement = list.getFields().get(0);
Preconditions.checkArgument(repeatedElement.isRepetition(Type.Repetition.REPEATED),
"Invalid list: inner group is not repeated");
- Preconditions.checkArgument(repeatedElement.getFieldCount() <= 1,
- "Invalid list: repeated group is not a single field: %s", list);
+
+ Type elementField = ParquetSchemaUtil.getListElementType(list);
visitor.beforeRepeatedElement(repeatedElement);
try {
T elementResult = null;
- if (repeatedElement.getFieldCount() > 0) {
- Type elementField = repeatedElement.getType(0);
+ if (repeatedElement.isPrimitive() ||
repeatedElement.asGroupType().getFieldCount() > 0) {
Review comment:
The changes to this class are inconsistent with the changes to the
`TypeWithSchemaVisitor`. Here, the repeated element is always visited
(`beforeRepeatedElement` call above) and may be processed again as the element.
The other avoids pushing the name on the stack. If `beforeRepeatedElement` were
used to track names, I think it would get a duplicate name for the repeated
group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
