kbendick commented on a change in pull request #3976:
URL: https://github.com/apache/iceberg/pull/3976#discussion_r791362705
##########
File path: site/docs/aws.md
##########
@@ -444,6 +444,9 @@ spark-sql --packages
org.apache.iceberg:iceberg-spark3-runtime:{{ versions.icebe
[Hive](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-hive.html),
[Flink](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-flink.html),
[Trino](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-presto.html)
that can run Iceberg.
+Recently, Amazon EMR 6.5.0
[announced](https://aws.amazon.com/about-aws/whats-new/2022/01/amazon-emr-supports-apache-iceberg/)
support of Apache Iceberg's Spark 3 Runtime.
Review comment:
Agreed.
it might help to think of it this way; Assume this addition to the docs
might not get updated for years, but that people might still read it (we will
almost certainly update before that, but for thinking through the correct
language think from that standpoint).
So qualifiers like `Recently` need to go (throughput). I think Jack’s
phrasing makes the most sense here. If need be, I’d be happy to help with
phrasing on other sections. But it should be treated like it could be read by
somebody years later, where phrases like “the current release” and “recently”
wouldn’t make sense then.
if they add needed context, they should probably be replaced with more
specific references to versions etc. In other places, things can probably just
be dropped.
For example, `With the current release` is ambiguous. So thinking forward to
3 years from now, that phrasing will definitely make things more confusing.
Relative time should be avoided at all costs so the docs can better
represent a snapshot in time. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
