kbendick commented on a change in pull request #3976:
URL: https://github.com/apache/iceberg/pull/3976#discussion_r791362705
##########
File path: site/docs/aws.md
##########
@@ -444,6 +444,9 @@ spark-sql --packages
org.apache.iceberg:iceberg-spark3-runtime:{{ versions.icebe
[Hive](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-hive.html),
[Flink](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-flink.html),
[Trino](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-presto.html)
that can run Iceberg.
+Recently, Amazon EMR 6.5.0
[announced](https://aws.amazon.com/about-aws/whats-new/2022/01/amazon-emr-supports-apache-iceberg/)
support of Apache Iceberg's Spark 3 Runtime.
Review comment:
Agreed.
it might help to think of it this way. Assume this addition to the docs
might not get updated for years.
So qualifiers like `Recently` need to go (throughput). I think Jack’s
phrasing makes the most sense here. If need be, I’d be happy to help with
phrasing on other sections. But it should be treated like it could be read by
somebody years later, where phrases like “the current release” and “recently”
wouldn’t make sense then.
##########
File path: site/docs/aws.md
##########
@@ -444,6 +444,9 @@ spark-sql --packages
org.apache.iceberg:iceberg-spark3-runtime:{{ versions.icebe
[Hive](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-hive.html),
[Flink](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-flink.html),
[Trino](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-presto.html)
that can run Iceberg.
+Recently, Amazon EMR 6.5.0
[announced](https://aws.amazon.com/about-aws/whats-new/2022/01/amazon-emr-supports-apache-iceberg/)
support of Apache Iceberg's Spark 3 Runtime.
Review comment:
Agreed.
it might help to think of it this way; Assume this addition to the docs
might not get updated for years, but that people might still read it (we will
almost certainly update before that, but for thinking through the correct
language think from that standpoint).
So qualifiers like `Recently` need to go (throughput). I think Jack’s
phrasing makes the most sense here. If need be, I’d be happy to help with
phrasing on other sections. But it should be treated like it could be read by
somebody years later, where phrases like “the current release” and “recently”
wouldn’t make sense then.
if they add needed context, they should probably be replaced with more
specific references to versions etc. In other places, things can probably just
be dropped.
For example, `With the current release` is ambiguous. So thinking forward to
3 years from now, that phrasing will definitely make things more confusing.
Relative time should be avoided at all costs so the docs can better
represent a snapshot in time. 🙂
##########
File path: site/docs/aws.md
##########
@@ -444,6 +444,9 @@ spark-sql --packages
org.apache.iceberg:iceberg-spark3-runtime:{{ versions.icebe
[Hive](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-hive.html),
[Flink](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-flink.html),
[Trino](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-presto.html)
that can run Iceberg.
+Recently, Amazon EMR 6.5.0
[announced](https://aws.amazon.com/about-aws/whats-new/2022/01/amazon-emr-supports-apache-iceberg/)
support of Apache Iceberg's Spark 3 Runtime.
+With the current release, you can use Apache Spark 3.1.2 on EMR clusters with
the Iceberg table format. Please refer the [official
documentation](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-iceberg-create-cluster.html)
to create a cluster with Iceberg installed.
Review comment:
So I understand this better myself, “the current release” is referring
to EMR 6.5.0 (or EMR in general)?
I would try to leave the version comparability information in the EMR docs
personally. EMR has a large number of releases that each support a unique set
of software. IIRC, There are really good docs for seeing what is supported
where.
So I would be in favor of deferring to the EMR docs for the exact
combination of dependencies.
Maybe `Starting with EMR version 6.5.0, EMR clusters can be configured to
have the necessary Apache Iceberg dependencies installed without requiring
bootstrap actions. Please refer to the official documentation on how to create
a cluster with Iceberg installed.`
Additionally, links to some sort of version support / dependency matrix
would go a long way. Given that this information is already well documented for
EMR for many things, it seems best to keep that there if possible as the
support matrix is quite large and changes over time.
##########
File path: site/docs/aws.md
##########
@@ -444,6 +444,9 @@ spark-sql --packages
org.apache.iceberg:iceberg-spark3-runtime:{{ versions.icebe
[Hive](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-hive.html),
[Flink](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-flink.html),
[Trino](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-presto.html)
that can run Iceberg.
+Recently, Amazon EMR 6.5.0
[announced](https://aws.amazon.com/about-aws/whats-new/2022/01/amazon-emr-supports-apache-iceberg/)
support of Apache Iceberg's Spark 3 Runtime.
+With the current release, you can use Apache Spark 3.1.2 on EMR clusters with
the Iceberg table format. Please refer the [official
documentation](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-iceberg-create-cluster.html)
to create a cluster with Iceberg installed.
Review comment:
So I understand this better myself, “the current release” is referring
to EMR 6.5.0 (or EMR in general)?
I would try to leave the version compatability information in the EMR docs
personally. EMR has a large number of releases that each support a unique set
of software. IIRC, There are really good docs for seeing what is supported
where.
So I would be in favor of deferring to the EMR docs for the exact
combination of dependencies supported etc.
Maybe `Starting with EMR version 6.5.0, EMR clusters officially support the
Apache Iceberg table format. EMR can be configured to have the necessary Apache
Iceberg dependencies installed without requiring the user to use additional
bootstrap actions to configure the cluster. Please refer to the official
documentation on how to create a cluster with Iceberg installed.`
Additionally, links to some sort of version support / dependency matrix
would go a long way. Given that this information is already well documented for
EMR for many things, it seems best to keep that there if possible as the
support matrix is quite large and changes over time.
##########
File path: site/docs/aws.md
##########
@@ -444,7 +444,10 @@ spark-sql --packages
org.apache.iceberg:iceberg-spark3-runtime:{{ versions.icebe
[Hive](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-hive.html),
[Flink](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-flink.html),
[Trino](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-presto.html)
that can run Iceberg.
-You can use a [bootstrap
action](https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-plan-bootstrap.html)
similar to the following to pre-install all necessary dependencies:
+Amazon EMR [added Apache
Iceberg](https://aws.amazon.com/about-aws/whats-new/2022/01/amazon-emr-supports-apache-iceberg/)
in distribution since 6.5.0.
+You can use Apache Spark 3.1.2 on EMR clusters with the Iceberg table format.
Please refer the [official
documentation](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-iceberg-create-cluster.html)
to create a cluster with Iceberg installed.
Review comment:
Is the information about Apache Spark 3.1.2 included in the link? Or is
there some sort of version compatibility matrix (or one that can be made for
use eventually)?
The specification of Spark version 3.1.2 is going to likely leave readers
with more questions re Spark 3.2 etc. That will be especially amplified in say,
6 months, when EMR will likely support Spark 3.2.x with some version of Iceberg
(just a guess but seems reasonable).
That’s one of my few remaining “relative time” related concerns.
Also, thanks for updating the docs @rajarshisarkar! I certainly don’t think
the docs won’t be updated for 3 years, but figured it might help as a way to
think about it.
##########
File path: site/docs/aws.md
##########
@@ -444,6 +444,9 @@ spark-sql --packages
org.apache.iceberg:iceberg-spark3-runtime:{{ versions.icebe
[Hive](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-hive.html),
[Flink](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-flink.html),
[Trino](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-presto.html)
that can run Iceberg.
+Recently, Amazon EMR 6.5.0
[announced](https://aws.amazon.com/about-aws/whats-new/2022/01/amazon-emr-supports-apache-iceberg/)
support of Apache Iceberg's Spark 3 Runtime.
+With the current release, you can use Apache Spark 3.1.2 on EMR clusters with
the Iceberg table format. Please refer the [official
documentation](https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-iceberg-create-cluster.html)
to create a cluster with Iceberg installed.
Review comment:
That’s ok. I know support is new, and im not sure how the EMR docs get
maintained / updated, but it would be great if that information could be
included with new releases like the choice of Spark / Flink versions etc is
included with different EMR releases (and I believe there’s a dependency matrix
that goes back some number of versions).
In the mid to long term, I think that’s by far the best solution. But this
makes sense for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
