RussellSpitzer commented on a change in pull request #3983:
URL: https://github.com/apache/iceberg/pull/3983#discussion_r792972740
##########
File path: api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
##########
@@ -113,6 +113,15 @@ default RewriteDataFiles sort(SortOrder sortOrder) {
throw new UnsupportedOperationException("SORT Rewrite Strategy not
implemented for this framework");
}
+ /**
+ * Choose Z-ORDER as a strategy for this rewrite operation with a specified
list of columns to use
+ * @param columns Columns to be used to generate Z-Values
+ * @return this for method chaining
+ */
+ default RewriteDataFiles zOrder(String... columns) {
Review comment:
For most types my goal would be to bound and the condense the byte
representation domain. So for example a column which has many values that
translate to
```
{0, ....., 0, 1, X, Y, Z}
```
We want to shift to
```
{1,x,y,z,0, ..., 0}
```
This involves finding min and max values, binning within that range and
shifting left
At least those are my current thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
