rdblue commented on a change in pull request #3774:
URL: https://github.com/apache/iceberg/pull/3774#discussion_r794112634
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -149,6 +142,29 @@
}
}
+ private static <T> T visitTwoLevelList(Types.ListType iListType,
Types.NestedField iListElement, GroupType pListType,
+ Type pListElement, TypeWithSchemaVisitor<T> visitor) {
+ T elementResult = visitField(iListElement, pListElement, visitor);
+
+ return visitor.list(iListType, pListType, elementResult);
+ }
+
+ private static <T> T visitThreeLevelList(Types.ListType iListType,
Types.NestedField iListElement,
+ GroupType pListType, Type pListElement, TypeWithSchemaVisitor<T>
visitor) {
+ visitor.fieldNames.push(pListType.getFieldName(0));
+
+ try {
+ T elementResult = null;
+ if (pListElement != null) {
Review comment:
The `determineListElementType` method doesn't perform the field count
check and return null, so this is always true. I think you may have thought
that `List.get` would return null? I think you can remove this null check and
always visit the field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
