rdblue commented on a change in pull request #3774:
URL: https://github.com/apache/iceberg/pull/3774#discussion_r795266372
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/TypeWithSchemaVisitor.java
##########
@@ -149,6 +142,29 @@
}
}
+ private static <T> T visitTwoLevelList(Types.ListType iListType,
Types.NestedField iListElement, GroupType pListType,
+ Type pListElement, TypeWithSchemaVisitor<T> visitor) {
+ T elementResult = visitField(iListElement, pListElement, visitor);
+
Review comment:
Don't worry about where still is incorrect in other places. We'll
eventually track those down and fix them, but we do want to keep style from
diverging when it is caught by a review. So please do fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]