rdblue commented on a change in pull request #3883:
URL: https://github.com/apache/iceberg/pull/3883#discussion_r795281601
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -529,6 +555,24 @@ public TableMetadata replaceProperties(Map<String, String>
rawProperties) {
.build();
}
+ public TableMetadata replaceRefs(Map<String, SnapshotRef> newRefs) {
Review comment:
I don't think that replacing all refs is a good idea. In fact, I would
probably avoid adding new mutation methods to `TableMetadata` in general and
have you go directly to the `TableMetadata.Builder` API.
That API should allow setting and removing individual refs and it should
reject removing the `main` ref. That way this class doesn't need to merge the
main branch back into anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
