rdblue commented on a change in pull request #3883:
URL: https://github.com/apache/iceberg/pull/3883#discussion_r795283188
##########
File path: core/src/main/java/org/apache/iceberg/util/JsonUtil.java
##########
@@ -134,6 +147,18 @@ public static String getStringOrNull(String property,
JsonNode node) {
.build();
}
+ public static void writeIntegerIfExists(String key, Integer value,
JsonGenerator generator) throws IOException {
Review comment:
In other places with a similar pattern, we move the whole boolean to the
caller so that this is a bit more flexible:
```java
JsonUtil.writeIntegerIf(v != null, "min-snapshots-to-keep", v, generator);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
