jun-he commented on pull request #3965: URL: https://github.com/apache/iceberg/pull/3965#issuecomment-1025444415
@rdblue @emkornfield Thanks for the comments. I improved the type classes using singleton pattern for non parameterized types. No equal or hash overriding is needed for them and default worked well. For parameterized ones, I still keep the equal method in this PR as currently type objects are not used as key in dict or set. It makes sense to use as key in the future and I will open a new PR to add hash overrides for them. I also updated the tests according to the comments. Can you please take another look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
