jun-he commented on a change in pull request #3965:
URL: https://github.com/apache/iceberg/pull/3965#discussion_r796841774
##########
File path: python/src/iceberg/types.py
##########
@@ -46,6 +46,9 @@ def __repr__(self):
def __str__(self):
return self._type_string
+ def __eq__(self, other):
Review comment:
@CircArgs wondering if it is better to keep Singleton out so any classes
can extend it to be singleton? l am also OK to move it into the `__new__` as
well. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
