CircArgs commented on a change in pull request #4016:
URL: https://github.com/apache/iceberg/pull/4016#discussion_r796630205
##########
File path: python/src/iceberg/types.py
##########
@@ -206,19 +204,14 @@ class IntegerType(Type):
min: int = -2147483648
- def __init__(self):
- super().__init__("int", "IntegerType()", is_primitive=True)
-
-class LongType(Type):
+class LongType(PrimitiveType):
"""A Long data type in Iceberg can be represented using an instance of
this class. Longs in Iceberg are
64-bit signed integers.
-
Example:
>>> column_foo = LongType()
>>> isinstance(column_foo, LongType)
True
-
Review comment:
Now I see I think I added the whitespace in the docstrings. They seem
much clearer with a line in between the descriptions and examples. Would you
like me to get rid of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
