rdblue commented on a change in pull request #4016:
URL: https://github.com/apache/iceberg/pull/4016#discussion_r796844790



##########
File path: python/tests/test_types.py
##########
@@ -63,7 +63,7 @@ def test_repr_primitive_types(input_type):
 def test_fixed_type():
     type_var = FixedType(length=5)
     assert type_var.length == 5
-    assert str(type_var) == "fixed[5]"
+    assert str(type_var) == "fixed<5>"

Review comment:
       There's a difference between the nested types that use `<>` and the 
primitive types that use `[]` or `()`. I think the inconsistency between fixed 
and decimal is probably my fault, but we can't really change it now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to