aokolnychyi commented on a change in pull request #4023:
URL: https://github.com/apache/iceberg/pull/4023#discussion_r796997751
##########
File path:
spark/v3.2/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/RowLevelCommandScanRelationPushDown.scala
##########
@@ -68,6 +68,20 @@ object RowLevelCommandScanRelationPushDown extends
Rule[LogicalPlan] with Predic
command.withNewRewritePlan(newRewritePlan)
}
+ private def pushFilters(
+ cond: Expression,
+ scanBuilder: ScanBuilder,
+ tableAttrs: Seq[AttributeReference]): (Seq[Filter], Seq[Expression]) = {
+
+ val tableAttrSet = AttributeSet(tableAttrs)
+ val filters =
splitConjunctivePredicates(cond).filter(_.references.subsetOf(tableAttrSet))
Review comment:
Yes, we did not split the condition before into parts and did not remove
filters that referenced both tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
