aokolnychyi commented on a change in pull request #4023:
URL: https://github.com/apache/iceberg/pull/4023#discussion_r797002039
##########
File path:
spark/v3.2/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/RowLevelCommandScanRelationPushDown.scala
##########
@@ -68,6 +68,20 @@ object RowLevelCommandScanRelationPushDown extends
Rule[LogicalPlan] with Predic
command.withNewRewritePlan(newRewritePlan)
}
+ private def pushFilters(
+ cond: Expression,
+ scanBuilder: ScanBuilder,
+ tableAttrs: Seq[AttributeReference]): (Seq[Filter], Seq[Expression]) = {
+
+ val tableAttrSet = AttributeSet(tableAttrs)
+ val filters =
splitConjunctivePredicates(cond).filter(_.references.subsetOf(tableAttrSet))
Review comment:
@szehon-ho ˆˆ
This comment provides a little bit more info to answer your question above.
We treated `t.id = s.id and t.dep IN ('hr')` as a single predicate that
couldn't be converted as it referenced both tables. Instead, we now split it
into parts and convert whatever we can (i.e. `t.dep IN ('hr')` in this case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
