CircArgs commented on a change in pull request #3965:
URL: https://github.com/apache/iceberg/pull/3965#discussion_r797036687
##########
File path: python/src/iceberg/types.py
##########
@@ -46,6 +46,9 @@ def __repr__(self):
def __str__(self):
return self._type_string
+ def __eq__(self, other):
Review comment:
@jun-he the Singleton way would make sense to me if it had use beyond
types I guess. If the functionality is limited to types I don't know if I can
see the difference in functionality since you'll be inheriting from it and
rather than hitting the `__new__` on the first parent it will hit it on the
second in the case of `class ...(Type, Singleton):...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
