rdblue commented on a change in pull request #4061:
URL: https://github.com/apache/iceberg/pull/4061#discussion_r802013150
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -267,6 +269,22 @@ public Builder uidPrefix(String newPrefix) {
return this;
}
+ public Builder customSnapshotMetadata(Map<String, String> metadata) {
+ if (this.customSnapshotMetadata == null) {
+ this.customSnapshotMetadata = Maps.newHashMap();
Review comment:
For a builder, I'd just initialize the metadata map to this rather than
having this `if`.
Also, accessing a field doesn't require `this.`. We only use the prefix when
setting a variable, so that it is clear that it is a field being set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
