liuml07 commented on a change in pull request #4061:
URL: https://github.com/apache/iceberg/pull/4061#discussion_r802106154
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -307,6 +310,9 @@ private void commitOperation(SnapshotUpdate<?> operation,
int numDataFiles, int
String newFlinkJobId, long checkpointId) {
LOG.info("Committing {} with {} data files and {} delete files to table
{}", description, numDataFiles,
numDeleteFiles, table);
+ if (customSnapshotMetadata != null) {
+ customSnapshotMetadata.forEach(operation::set);
+ } // custom snapshot metadata properties will be overridden if they
conflict with reversed ones.
Review comment:
Oh, by "reserved" I meant the one that is set by the Flink file
committer in the next two lines. They are currently
`flink.max-committed-checkpoint-id` and `flink.job-id` but could be more in
future. Maybe I can use "internal" here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
