emkornfield commented on a change in pull request #4081:
URL: https://github.com/apache/iceberg/pull/4081#discussion_r803310753
##########
File path: python/src/iceberg/io/base.py
##########
@@ -142,12 +158,25 @@ class FileIO(ABC):
@abstractmethod
def new_input(self, location: str) -> InputFile:
- """Get an InputFile instance to read bytes from the file at the given
location"""
+ """Get an InputFile instance to read bytes from the file at the given
location
+
+ Args:
+ location(str): The URI to the file
+ """
@abstractmethod
def new_output(self, location: str) -> OutputFile:
- """Get an OutputFile instance to write bytes to the file at the given
location"""
+ """Get an OutputFile instance to write bytes to the file at the given
location
+
+ Args:
+ location(str): The URI to the file
Review comment:
small nit, this isn't always a URI is it? For local file systems it is
just a file path which I don't think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
