samredai commented on a change in pull request #4081:
URL: https://github.com/apache/iceberg/pull/4081#discussion_r803831390
##########
File path: python/src/iceberg/io/base.py
##########
@@ -142,12 +158,25 @@ class FileIO(ABC):
@abstractmethod
def new_input(self, location: str) -> InputFile:
- """Get an InputFile instance to read bytes from the file at the given
location"""
+ """Get an InputFile instance to read bytes from the file at the given
location
+
+ Args:
+ location(str): The URI to the file
+ """
@abstractmethod
def new_output(self, location: str) -> OutputFile:
- """Get an OutputFile instance to write bytes to the file at the given
location"""
+ """Get an OutputFile instance to write bytes to the file at the given
location
+
+ Args:
+ location(str): The URI to the file
Review comment:
As it stands the user would have to use `file://...` but I totally
agree. The code here should make an assumption that if the URI is missing a
scheme that it's just a local filepath. I'll update the code and change the
docstring to say "A URI or a path to a local file"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
