danielcweeks commented on pull request #4050: URL: https://github.com/apache/iceberg/pull/4050#issuecomment-1036602165
@nastra @szehon-ho @RussellSpitzer @rdblue @jackye1995 @kbendick Thanks for all the feedback. This is an updated version of the PR that includes the changes discussed including: - Up-leveling the metrics to be more generic so we can use them in other areas like scan planning - Renaming to `MetricsContext` and placing in the `org.apache.iceberg.metrics` package to avoid confusion with other metrics concepts Note there is still a `FileIOMetricsContext` class, but it is purely to further scope the properties we want to use as the standard metrics for the FileIO implementations; this include S3FileIO, but GCSFileIO, OSSFileIO, can be follow-ons that reuse the `HadoopMetricsContext` to provide consistent implementations. For future use cases, I added a `Unit` concept to the counter so we are explicit about what the metric value is when reporting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
