jackye1995 commented on a change in pull request #4102:
URL: https://github.com/apache/iceberg/pull/4102#discussion_r805441635
##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/DynamoLockManager.java
##########
@@ -60,8 +60,9 @@
import
software.amazon.awssdk.services.dynamodb.model.TransactionConflictException;
/**
- * DynamoDB implementation for the lock manager.
+ * @deprecated will be removed in 0.15.0, please use {@link
org.apache.iceberg.aws.dynamodb.DynamoDbLockManager}
*/
+@Deprecated
class DynamoLockManager extends LockManagers.BaseLockManager {
Review comment:
my intention for doing that copy was to fully remove this class after 2
releases, and people who see this class can know it should not be used anymore.
But extending also works, I don't have a strong opinion of which way is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
