rdblue commented on a change in pull request #4126:
URL: https://github.com/apache/iceberg/pull/4126#discussion_r807368047
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java
##########
@@ -151,4 +168,31 @@ TableCatalog tableCatalog() {
return tableCatalog;
}
}
+
+ /**
+ * Closes the procedure's executor service if a new one was created.
+ */
+ protected void closeService() {
+ if (executorService != null) {
+ executorService.shutdown();
+ try {
+ executorService.awaitTermination(1, TimeUnit.SECONDS);
+ } catch (InterruptedException e) {
+ throw new RuntimeException("Internal Error, Procedure closeService was
called before all tasks were finished");
+ }
+ }
+ }
+
+ protected ExecutorService executorService(int concurrentDeletes, String
nameFormat) {
+ Preconditions.checkArgument(executorService == null, "Cannot create a new
executor service, one already exists.");
+ Preconditions.checkArgument(nameFormat != null, "Cannot create a service
with null nameFormat arg");
+ executorService = MoreExecutors.getExitingExecutorService(
Review comment:
Nit: `this.executorService` since this is modifying shared state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
