RussellSpitzer commented on a change in pull request #4126:
URL: https://github.com/apache/iceberg/pull/4126#discussion_r808338455
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java
##########
@@ -71,11 +77,21 @@ protected TableCatalog tableCatalog() {
}
protected <T> T modifyIcebergTable(Identifier ident,
Function<org.apache.iceberg.Table, T> func) {
- return execute(ident, true, func);
+ try {
+ T result = execute(ident, true, func);
+ return result;
Review comment:
Good call. I previously had the close after the execute, but realized I
wanted it in a finally block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
