0xffmeta commented on a change in pull request #4152:
URL: https://github.com/apache/iceberg/pull/4152#discussion_r809725261
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java
##########
@@ -83,6 +84,7 @@ public StructType outputType() {
Long olderThanMillis = args.isNullAt(1) ? null :
DateTimeUtil.microsToMillis(args.getLong(1));
Integer retainLastNum = args.isNullAt(2) ? null : args.getInt(2);
Integer maxConcurrentDeletes = args.isNullAt(3) ? null : args.getInt(3);
+ Boolean streamResult = args.isNullAt(4) ? false : args.getBoolean(4);
Review comment:
@aokolnychyi Just updated the PR to include the suggested the change and
test cases.
For the test cases
- the original `testUseLocalIterator` method might be a legacy test case
(right now it uses `collectAsList` by default), so I renamed the method
- Use `spark.sql.adaptive.enabled=false` conf to reduce the AQE impact since
spark 3.2 enables this feature by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
