RussellSpitzer commented on a change in pull request #4152:
URL: https://github.com/apache/iceberg/pull/4152#discussion_r810390942
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java
##########
@@ -102,6 +104,10 @@ public StructType outputType() {
action.executeDeleteWith(executorService(maxConcurrentDeletes,
"expire-snapshots"));
}
+ if (streamResult) {
+ action.option("stream-results", streamResult.toString());
Review comment:
The reason for #1395 if anyone remembers is that having toLocalIterator
on made this test suite take on the order of ten's of minutes. I'm not sure
what happened here though
https://github.com/apache/iceberg/pull/1395/files#diff-c514ec43081677e77a31b19f98b424734da476b74043733d79f37c924b5dad5eR1031-R1032
As the test that was renamed to "testCollectAsList" was actually using the
local iterator before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
