kbendick commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r810391506
########## File path: core/src/test/java/org/apache/iceberg/rest/requests/TestCreateNamespaceRequest.java ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.requests; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.ObjectMapper; +import java.util.Map; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.util.JsonUtil; +import org.assertj.core.api.Assertions; +import org.junit.Test; + +public class TestCreateNamespaceRequest { + + private static final ObjectMapper MAPPER = JsonUtil.withRESTComponents(); + + private static final String[] ALL_FIELDS_FROM_SPEC = { "namespace", "properties" }; + + /* Values used to fill in request fields */ + private static final Namespace NAMESPACE = Namespace.of("accounting", "tax"); + private static final Map<String, String> PROPERTIES = ImmutableMap.of("owner", "Hank"); + + /* JSON of requests */ + private static final String JSON_REQUEST = + "{\"namespace\":[\"accounting\",\"tax\"],\"properties\":{\"owner\":\"Hank\"}}"; + private static final String JSON_REQUEST_EMPTY_PROPERTIES = + "{\"namespace\":[\"accounting\",\"tax\"],\"properties\":{}}"; + + @Test + public void testDeserialize() throws JsonProcessingException { + CreateNamespaceRequest expected = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE) + .withProperties(PROPERTIES) + .build(); + + CreateNamespaceRequest actual = MAPPER.readValue(JSON_REQUEST, CreateNamespaceRequest.class); + + assertEquals(expected, actual); + assertHasOnlyKnownFields(expected); + assertHasOnlyKnownFields(actual); + } + + @Test + public void testDeserializeEmptyProperties() throws JsonProcessingException { + CreateNamespaceRequest expected = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE) + .build(); + + CreateNamespaceRequest actual = MAPPER.readValue(JSON_REQUEST_EMPTY_PROPERTIES, CreateNamespaceRequest.class); + + assertEquals(expected, actual); + assertHasOnlyKnownFields(expected); + assertHasOnlyKnownFields(actual); + } + + @Test + public void testSerialize() throws JsonProcessingException { + CreateNamespaceRequest req = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE) + .withProperties(PROPERTIES) + .build(); + + Assertions.assertThat(MAPPER.writeValueAsString(req)) + .isEqualTo(JSON_REQUEST); + } + + @Test + public void testSerializeEmptyProperties() throws JsonProcessingException { + CreateNamespaceRequest req = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE) + .build(); + + Assertions.assertThat(MAPPER.writeValueAsString(req)) + .isEqualTo(JSON_REQUEST_EMPTY_PROPERTIES); + } + + private static void assertEquals(CreateNamespaceRequest expected, CreateNamespaceRequest actual) { + Assertions.assertThat(actual.namespace()).isEqualTo(expected.namespace()); Review comment: So implementing `equals` lead to having to jump through a lot of hoops to ensure the builder couldn't create values with `null` where not accessed (and lazily instantiate a number of things). Long story short, it lead to writing a lot of code that was more to get tests to pass than for the class to work. So I've extracted out an abstract base test class, and then it required the implementation of `assertEquals`. It also still checks that it knows of all fields. So if somebody adds a field, it will be caught by the test. I can show you further, but it was definitely uglier due to comparing `null` with empty collections (`null` coming from deserialization and empty collections coming from the builder by default). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
