kbendick commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r810294198
########## File path: core/src/main/java/org/apache/iceberg/rest/requests/CreateNamespaceRequest.java ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.requests; + +import java.util.Map; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; + +/** + * A REST request to create a namespace, with an optional set of properties. + * The server might also add properties, such as `last_modified_time` etc. + */ +public class CreateNamespaceRequest { + + private Namespace namespace; + private Map<String, String> properties; + + public CreateNamespaceRequest() { + // Required for Jackson deserialization + } + + private CreateNamespaceRequest(Namespace namespace, Map<String, String> properties) { + this.namespace = namespace; + this.properties = properties; + } + + public static Builder builder() { + return new Builder(); + } + + public Namespace namespace() { + return namespace; + } + + public Map<String, String> properties() { + return ImmutableMap.copyOf(properties); + } + + @Override + public String toString() { + return MoreObjects.toStringHelper(this) + .add("namespace", namespace) + .add("properties", properties) + .toString(); + } + + public static class Builder { + private Namespace namespace; + private ImmutableMap.Builder<String, String> properties = ImmutableMap.builder(); + + private Builder() { + } + + public Builder withNamespace(Namespace ns) { + this.namespace = ns; + return this; + } + + public Builder withProperties(Map<String, String> props) { + this.properties.putAll(props); + return this; + } + + public CreateNamespaceRequest build() { + Preconditions.checkArgument( + namespace != null && !namespace.isEmpty(), + "Cannot build a response to create a namespace without specifying the namespace"); Review comment: This got moved around, but the assertion message is still tested against (as well as pretty much every precondition path). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
