wuwenchi commented on a change in pull request #4162:
URL: https://github.com/apache/iceberg/pull/4162#discussion_r810462879
##########
File path:
core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesAction.java
##########
@@ -300,6 +301,11 @@ void doReplace(Iterable<DataFile> deletedDataFiles,
Iterable<DataFile> addedData
private boolean isPartialFileScan(CombinedScanTask task) {
if (task.files().size() == 1) {
FileScanTask fileScanTask = task.files().iterator().next();
+ if (fileScanTask.file().format() == FileFormat.PARQUET) {
+ // in parquet format, there is an initial offset of 4 bytes
+ return fileScanTask.file().fileSizeInBytes() !=
+ (fileScanTask.length() +
fileScanTask.file().splitOffsets().get(0));
Review comment:
That sounds good.
I will add `public static final int PARQUET_MAGIC_BYTES = 4;` in `Parquet`
class,
and use `Parquet.PARQUET_MAGIC_BYTES` instead of
`fileScanTask.file().splitOffsets().get(0)`.
Is it ok?
##########
File path:
core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesAction.java
##########
@@ -300,6 +301,11 @@ void doReplace(Iterable<DataFile> deletedDataFiles,
Iterable<DataFile> addedData
private boolean isPartialFileScan(CombinedScanTask task) {
if (task.files().size() == 1) {
FileScanTask fileScanTask = task.files().iterator().next();
+ if (fileScanTask.file().format() == FileFormat.PARQUET) {
+ // in parquet format, there is an initial offset of 4 bytes
+ return fileScanTask.file().fileSizeInBytes() !=
+ (fileScanTask.length() +
fileScanTask.file().splitOffsets().get(0));
+ }
return fileScanTask.file().fileSizeInBytes() != fileScanTask.length();
Review comment:
yes, if it is a complete file scan, fileScanTask.length() will also not
contain offset of 4 bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
